Notices
ECU Flash

bad scaling definition for max downward WGDCC

Thread Tools
 
Search this Thread
 
Old Jan 2, 2010 | 02:50 PM
  #1  
mrfred's Avatar
Thread Starter
EvoM Guru
iTrader: (50)
 
Joined: Mar 2006
Posts: 9,675
Likes: 132
From: Tri-Cities, WA // Portland, OR
bad scaling definition for max downward WGDCC

Hey Folks,

Just found out that the scaling definition that I used for the Max Downward WGDCC table is incorrect. Using the stock value is modified using the incorrect scaling large positive WGDCC values may result. Find the "OffsetWGDC" scaling in your evo9base.xml or evo7base.xml file and replace it with:

Code:
<scaling name="OffsetWGDC" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint16" endian="big"/>
Reply
Old Jan 2, 2010 | 03:32 PM
  #2  
black E's Avatar
Evolved Member
15 Year Member
Liked
Loved
Community Favorite
iTrader: (77)
 
Joined: Mar 2007
Posts: 546
Likes: 45
From: Boca Raton FL
so what is that table used for?
Reply
Old Jan 2, 2010 | 03:49 PM
  #3  
nonschlont's Avatar
Evolved Member
iTrader: (3)
 
Joined: Mar 2007
Posts: 1,760
Likes: 2
From: Ca
I replaced this scaling for the old one, and it scewed the upward correction table. The downward tables was still @ -64%
Reply
Old Jan 2, 2010 | 06:50 PM
  #4  
SoCalRedLine's Avatar
Evolving Member
iTrader: (2)
 
Joined: Mar 2007
Posts: 298
Likes: 0
From: NorCal
good find!
Reply
Old Jan 2, 2010 | 07:19 PM
  #5  
Appauldd's Avatar
Evolved Member
iTrader: (22)
 
Joined: Nov 2003
Posts: 2,408
Likes: 7
From: Northern KY near Cincy
Originally Posted by nonschlont
i replaced this scaling for the old one, and it scewed the upward correction table. The downward tables was still @ -64%
^..+1
Reply
Old Jan 2, 2010 | 08:10 PM
  #6  
mrfred's Avatar
Thread Starter
EvoM Guru
iTrader: (50)
 
Joined: Mar 2006
Posts: 9,675
Likes: 132
From: Tri-Cities, WA // Portland, OR
Originally Posted by nonschlont
I replaced this scaling for the old one, and it scewed the upward correction table. The downward tables was still @ -64%
Crap. You're right. Now its getting more complicated. Two separate scalings are needed for the Max Upward and Max Downward correction tables. Use the OffsetWGDC-8 for the Max Upward correction, and use OffsetWGDC-16 for the Max Downward correction.

Code:
<scaling name="OffsetWGDC-8" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint8" endian="big"/>
<scaling name="OffsetWGDC-16" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint16" endian="big"/>
Reply
Old Jan 2, 2010 | 08:29 PM
  #7  
mrfred's Avatar
Thread Starter
EvoM Guru
iTrader: (50)
 
Joined: Mar 2006
Posts: 9,675
Likes: 132
From: Tri-Cities, WA // Portland, OR
Originally Posted by razorlab
Wow you are quick.

- Bryan
This is a nasty one, so I figure I should fix it ASAP.
Reply
Old Jan 2, 2010 | 08:37 PM
  #8  
Appauldd's Avatar
Evolved Member
iTrader: (22)
 
Joined: Nov 2003
Posts: 2,408
Likes: 7
From: Northern KY near Cincy
We will need to keep the original Offset WGDC scaling too. If we change it...the Boost Error Correction table and MAF IAT WGDC table get messed up.

Oh what a can of worms this became.
Reply
Old Jan 2, 2010 | 08:41 PM
  #9  
Appauldd's Avatar
Evolved Member
iTrader: (22)
 
Joined: Nov 2003
Posts: 2,408
Likes: 7
From: Northern KY near Cincy
My v7 is missing the Max Downward table....someone please post the XML ? ?
Reply
Old Jan 4, 2010 | 11:52 AM
  #10  
fostytou's Avatar
EvoM Community Team
iTrader: (15)
 
Joined: Sep 2006
Posts: 3,143
Likes: 7
From: Aurora, IL
Originally Posted by Appauldd
My v7 is missing the Max Downward table....someone please post the XML ? ?
for 88590015:

Code:
  <scaling name="OffsetWGDC-8" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint8" endian="big"/>
  <scaling name="OffsetWGDC-16" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint16" endian="big"/>
  
  <table name="Max Total Upward WGDC Correction vs TPS" category="Turbo Boost Single Solenoid" type="2D" scaling="OffsetWGDC-8">
    <table name="TPS" type="Y Axis" elements="9" scaling="ThrottlePercentage"/>
  </table>
  
  <table name="Max Total Downward WGDC Correction" category="Turbo Boost Single Solenoid" type="1D" level="3" scaling="OffsetWGDC-16"/>


  <table name="Max Total Upward WGDC Correction vs TPS" address="3f10">
    <table name="TPS" address="7284"/>
  </table>
  
  <table name="Max Total Downward WGDC Correction" address="1658"/>

Last edited by fostytou; Jan 4, 2010 at 11:55 AM.
Reply
Old Jan 4, 2010 | 06:51 PM
  #11  
Appauldd's Avatar
Evolved Member
iTrader: (22)
 
Joined: Nov 2003
Posts: 2,408
Likes: 7
From: Northern KY near Cincy
Cool beans.....now if I could just get the addresses for v7 9653.
Reply
Old Jan 4, 2010 | 07:32 PM
  #12  
logic's Avatar
Evolved Member
iTrader: (2)
 
Joined: Apr 2003
Posts: 1,022
Likes: 7
From: Berkeley, CA
9653:
PHP Code:
<scaling name="OffsetWGDC-8" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint8" endian="big"/>
<scaling name="OffsetWGDC-16" units="%WGDC Change" toexpr="(x-128)/2" frexpr="x*2+128" format="%.1f" min="-64" max="63.5" inc="0.1" storagetype="uint16" endian="big"/>

<table name="Max Total Upward WGDC Correction vs TPS" address="448a" category="Turbo Boost Single Solenoid" type="2D" scaling="OffsetWGDC-8">
    <table name="TPS" address="6c2a" type="Y Axis" elements="9" scaling="ThrottlePercentage"/>
</table>

<table name="Max Total Downward WGDC Correction" address="1a58" category="Turbo Boost Single Solenoid" type="1D" level="3" scaling="OffsetWGDC-16"/> 

Last edited by logic; Jan 5, 2010 at 06:58 AM.
Reply
Old Jan 4, 2010 | 08:42 PM
  #13  
Appauldd's Avatar
Evolved Member
iTrader: (22)
 
Joined: Nov 2003
Posts: 2,408
Likes: 7
From: Northern KY near Cincy
Ed....you are missing a / before the > on the Downward table.
Reply
Old Jan 5, 2010 | 06:58 AM
  #14  
logic's Avatar
Evolved Member
iTrader: (2)
 
Joined: Apr 2003
Posts: 1,022
Likes: 7
From: Berkeley, CA
Good catch. Fixed.
Reply
Old Jan 5, 2010 | 08:35 AM
  #15  
Danieln's Avatar
Evolved Member
iTrader: (1)
 
Joined: Apr 2008
Posts: 563
Likes: 0
From: EUROPE
Can you please post also the tables for 88570008 please.....

Much appreciated....
Reply



All times are GMT -7. The time now is 01:07 PM.